Fix compilation for target x86_64-unknown-linux-musl.
#1180
Conversation
losfair
requested review from
Hywan,
MarkMcCaskey and
syrusakbary
as code owners
|
bors try |
|
bors try- |
|
bors try |
| Some(read_xmm(&fpregs._xmm[15])); | ||
| // Skip reading floating point registers when building with musl libc. | ||
| // FIXME: Depends on https://github.com/rust-lang/libc/pull/1646 | ||
| #[cfg(not(target_env = "musl"))] |
There was a problem hiding this comment.
Do we need to handle the other case too? Like
#[cfg(target_env = "musl")]
unimplemented!("blocked on https://github.com/rust-lang/libc/pull/1646");
Or will it work fine as-is?
There was a problem hiding this comment.
This is on the always-taken path for fault handling so panicking here will break things that depend on fault handling, like middlewares. Now all XMM registers will be defaulted to zero if not dumped; do you think it is fine?
There was a problem hiding this comment.
Hmm, I'm not familiar enough to know what the impacts of that are: if you think this leaves the system in a sensible state where execution makes sense then I'm happy with it! Otherwise, I don't think compiling and failing silently is necessarily a step up from panicking or not compiling.
There was a problem hiding this comment.
The only case where doing so is possibly incorrect is when we take a managed snapshot and then unwind out from WebAssembly code (where floating point state will be lost). This feature is not widely used (yet) and I think it is "cold" enough to ignore for now and defer to after a future upstream fix in musl-libc.
There was a problem hiding this comment.
Okay, that sounds reasonable to me! We just need to remember to not forget to update this!
tryBuild succeeded
|
|
bors r+ |
1180: Fix compilation for target `x86_64-unknown-linux-musl`. r=losfair a=losfair Fixes compilation failure when built for `x86_64-unknown-linux-musl`. - Allows disabling the `wabt` feature to avoid depending on a C++ compiler. - Disables XMM register dump on fault as a workaround for missing musl libc types (rust-lang/libc#1646). Fixes #1178 and #1173 . Co-authored-by: losfair <[email protected]>
Build succeeded
|
Fixes compilation failure when built for
x86_64-unknown-linux-musl.wabtfeature to avoid depending on a C++ compiler.Fixes #1178 and #1173 .